Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-Backward-Compatible Change to YAML Renderer #4

Merged
merged 4 commits into from
Jul 9, 2019
Merged

Non-Backward-Compatible Change to YAML Renderer #4

merged 4 commits into from
Jul 9, 2019

Conversation

kartnico
Copy link
Contributor

For this issue : #3

myii
myii requested changes Jun 25, 2019
View reviewed changes
Copy link
Member

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kartnico Thanks for this PR. Please refer to the linked comment.

nut/server.sls Outdated Show resolved Hide resolved
nut/server.sls Outdated Show resolved Hide resolved
nut/server.sls Outdated Show resolved Hide resolved
@javierbertoli
Copy link
Member

@kartnico any change you can submit the changes @myii suggest? As he mentions, we found (while dealing with this same issue in other formulas) that | json has the same effect that | tojson and is backward compatible.

kartnico and others added 3 commits July 9, 2019 15:30
@kartnico @myii
Update nut/server.sls
0275f09 
Co-Authored-By: Imran Iqbal <[email protected]>
@kartnico @myii
Update nut/server.sls
d6f3fc6 
Co-Authored-By: Imran Iqbal <[email protected]>
@kartnico @myii
Update nut/server.sls
990a98f 
Co-Authored-By: Imran Iqbal <[email protected]>
@myii myii merged commit c1ea282 into saltstack-formulas:master Jul 9, 2019
@myii
Copy link
Member

myii commented Jul 9, 2019

Merged, thanks @kartnico and also @javierbertoli.

@myii myii mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myii myii myii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartnico @javierbertoli @myii